Skip to content

Conversation

@igoragoli
Copy link
Contributor

@igoragoli igoragoli commented Nov 17, 2025

Overview

Set interruptible: true on benchmarking jobs outside main and /^release\/v/ refs as they become redundant on new runs.

Motivation

#incident-45572 and APMSP-2369.

Testing

Cancelled pipeline (bottom right) after a dummy commit is pushed:

image

@igoragoli igoragoli requested a review from a team as a code owner November 17, 2025 12:34
@igoragoli igoragoli requested review from zacharycmontoya and removed request for a team November 17, 2025 12:34
@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.42%. Comparing base (39de9cb) to head (c2ffab2).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #272   +/-   ##
=======================================
  Coverage   68.42%   68.42%           
=======================================
  Files          56       56           
  Lines        6030     6030           
  Branches     1049     1049           
=======================================
  Hits         4126     4126           
  Misses       1397     1397           
  Partials      507      507           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@igoragoli igoragoli marked this pull request as draft November 17, 2025 12:55
@igoragoli igoragoli force-pushed the augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy branch 2 times, most recently from c2ffab2 to 7c111f5 Compare November 18, 2025 08:43
@igoragoli igoragoli force-pushed the augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy branch from 097e763 to 6ce82f6 Compare November 18, 2025 08:48
@igoragoli igoragoli marked this pull request as ready for review November 18, 2025 08:51
@igoragoli igoragoli requested a review from dubloom November 18, 2025 08:52
@igoragoli igoragoli changed the title chore(ci): benchmarking jobs must be interruptible as they become redundant chore(ci): set benchmarking jobs to be interruptible outside main/releases Nov 18, 2025
@igoragoli igoragoli merged commit 0bb4e3d into master Nov 18, 2025
86 of 87 checks passed
@igoragoli igoragoli deleted the augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy branch November 18, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants